Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hover on assignments to subrecords #1725

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix hover on assignments to subrecords #1725

merged 1 commit into from
Nov 29, 2023

Conversation

jneem
Copy link
Member

@jneem jneem commented Nov 28, 2023

A subrecord assignment like { foo.bar = 1 } gets desugared into a Record, not a RecRecord. Since we forgot to handle Record, we were missing out on some definitions.

In particular, hovering over the first bar in { foo.bar = 1 } | { foo.bar | doc "hi" } now works.

@jneem jneem requested review from yannham and vkleen November 28, 2023 21:47
@github-actions github-actions bot temporarily deployed to pull request November 28, 2023 21:51 Inactive
@jneem jneem added this pull request to the merge queue Nov 29, 2023
Merged via the queue into master with commit 2c8cdfc Nov 29, 2023
5 checks passed
@jneem jneem deleted the more-hover branch November 29, 2023 17:47
@Porkepix Porkepix mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannham yannham yannham approved these changes

@vkleen vkleen Awaiting requested review from vkleen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jneem @yannham